Skip to content

perf(linter/no-required-prop-with-default): restructure so lintgen works#20537

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/03-19-perf_linter_no-required-prop-with-default_restructure_so_lintgen_works
Mar 19, 2026
Merged

perf(linter/no-required-prop-with-default): restructure so lintgen works#20537
graphite-app[bot] merged 1 commit intomainfrom
c/03-19-perf_linter_no-required-prop-with-default_restructure_so_lintgen_works

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Mar 19, 2026

No description provided.

@camc314 Graphite App
Copy link
Copy Markdown
Contributor Author

camc314 commented Mar 19, 2026

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Mar 19, 2026
@camc314 camc314 self-assigned this Mar 19, 2026
@camc314 camc314 marked this pull request as ready for review March 19, 2026 22:38
Copilot AI review requested due to automatic review settings March 19, 2026 22:38
Copilot AI reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Vue rule no-required-prop-with-default so it can be lintgen-friendly and more selective about which AST nodes it runs on, improving runtime efficiency while preserving existing behavior.

Changes:

  • Restructured the rule’s run logic to dispatch only on CallExpression and (Vue-only) ExportDefaultDeclaration.
  • Converted some helper methods to associated functions and switched ancestor lookup to use NodeId directly.
  • Updated the generated RuleRunner impl to declare concrete NODE_TYPES for this rule.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/rules/vue/no_required_prop_with_default.rs Refactors rule entrypoints to operate on explicit node kinds and use NodeId for ancestor traversal.
crates/oxc_linter/src/generated/rule_runner_impls.rs Narrows this rule’s runner to CallExpression + ExportDefaultDeclaration to match the refactor and improve performance.

@camc314 camc314 force-pushed the c/03-19-perf_linter_no-required-prop-with-default_restructure_so_lintgen_works branch from 8693ed2 to 3555c33 Compare March 19, 2026 22:41
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 19, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks1

Comparing c/03-19-perf_linter_no-required-prop-with-default_restructure_so_lintgen_works (3555c33) with main (c5f0ed3)

Open in CodSpeed

Footnotes

  1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314
Copy link
Copy Markdown
Contributor Author

camc314 commented Mar 19, 2026

As expected:

Screenshot 2026-03-19 at 22 52 48

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 19, 2026
@camc314 Graphite App
Copy link
Copy Markdown
Contributor Author

camc314 commented Mar 19, 2026 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the c/03-19-perf_linter_no-required-prop-with-default_restructure_so_lintgen_works branch from 3555c33 to 57b2e82 Compare March 19, 2026 22:55
@graphite-app graphite-app bot merged commit 57b2e82 into main Mar 19, 2026
21 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 19, 2026
@graphite-app graphite-app bot deleted the c/03-19-perf_linter_no-required-prop-with-default_restructure_so_lintgen_works branch March 19, 2026 23:01
costajohnt pushed a commit to costajohnt/oxc that referenced this pull request Mar 22, 2026
@camc314 @costajohnt
perf(linter/no-required-prop-with-default): restructure so lintgen wo…
3816b68 
…rks (oxc-project#20537)
This was referenced Mar 23, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314